Skip to content

[9.0.0] Verify Unicode environment variable name sorting in tests #28058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bazel-io wants to merge 1 commit into
base: release-9.0.0
Choose a base branch
from
Open

[9.0.0] Verify Unicode environment variable name sorting in tests #28058

bazel-io wants to merge 1 commit into from

Conversation

@bazel-io
Copy link
Member

@bazel-io bazel-io commented Dec 18, 2025

Related to #26745

Closes #28035.

PiperOrigin-RevId: 846391505
Change-Id: Ib414b80de550f9600d45c57f3eb8aba9c5ffea5c

Commit 79b9a98

@fmeum @bazel-io
Verify Unicode environment variable name sorting in tests
22e9647 
Related to bazelbuild#26745

Closes bazelbuild#28035.

PiperOrigin-RevId: 846391505
Change-Id: Ib414b80de550f9600d45c57f3eb8aba9c5ffea5c
@bazel-io bazel-io added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Dec 18, 2025
@bazel-io bazel-io requested a review from a team as a code owner December 18, 2025 21:24
@bazel-io bazel-io added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Dec 18, 2025
@bazel-io bazel-io requested a review from tjgq December 18, 2025 21:24
@bazel-io bazel-io added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 18, 2025
@bazel-io bazel-io mentioned this pull request Dec 18, 2025
Open
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 18, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a test to verify that environment variable names with Unicode characters are sorted correctly according to their UTF-8 byte representation. The change is correct and improves test coverage for Unicode handling.

@iancha1992 iancha1992 enabled auto-merge December 18, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjgq tjgq Awaiting requested review from tjgq

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bazel-io @fmeum