Updates missing documentation about infoplists parameter for ios_unit_test and ios_ui_test rules#2777
Updates missing documentation about infoplists parameter for ios_unit_test and ios_ui_test rules#2777maciejpiotrowski89 wants to merge 3 commits intobazelbuild:mainfrom
infoplists parameter for ios_unit_test and ios_ui_test rules#2777Conversation
maciejpiotrowski89
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
You'll also need to sign the CLA. |
| # Add bundle attributes to make them visible in documentation | ||
| rule_attrs.infoplist_attrs(), | ||
| { | ||
| "bundle_name": attr.string( | ||
| mandatory = False, | ||
| doc = """ | ||
| The desired name of the bundle (without the extension). If this attribute is not set, then the name | ||
| of the target will be used instead. | ||
| """, | ||
| ), | ||
| "frameworks": attr.label_list( | ||
| providers = [[AppleBundleInfo]], | ||
| doc = """ | ||
| A list of framework targets that this target depends on. | ||
| """, | ||
| ), | ||
| }, |
There was a problem hiding this comment.
This causes the test runner to be invalidated when these values change. I don't like that. Longer term it might be best to separate the test runner from the bundle (#2744 (comment)).
Short term, we could adjust apple/ios.doc.bzl and the like to point to the macro in apple/ios.bzl and add a hand-crafted docstring.
2 participants
What
Adds
infoplistsparameter to documentation forios_unit_testandios_ui_testrules. Links to problem described in Issue #2776