Implement apple_archive rule to stop generating .ipa and .zip files from {platform}_application targets#2839
Draft
Implement apple_archive rule to stop generating .ipa and .zip files from {platform}_application targets#2839
apple_archive rule to stop generating .ipa and .zip files from {platform}_application targets#2839Conversation
apple_archive rule to stop generating .ipa and .zip files from *_application targetsapple_archive rule to stop generating .ipa and .zip files from {platform}_application targets
c1a0b93 to
cdec29c
Compare
b74acfd to
98f0d14
Compare
37e7ef0 to
a5c6700
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to decouple creation of
.ipaand.zipfiles from{platform}_applicationrules. This implies enabling tree artifacts for those application rules by default.apple_archivetargets which now exercise this rule.Remaining things to do:
ipa_post_processortopost_processor.ziparchives formacos_application. This is a little tricky since there is framework rules that don't support tree artifacts for macOS.processor.bzl