Update rules_apple to use the the new swift_common toolchain APIs.#2848
Open
brentleyjones wants to merge 1 commit intomainfrom
Open
Update rules_apple to use the the new swift_common toolchain APIs.#2848brentleyjones wants to merge 1 commit intomainfrom
swift_common toolchain APIs.#2848brentleyjones wants to merge 1 commit intomainfrom
Conversation
Also remove the explicit execution group and the workaround that disabled auto-exec-groups, because the underlying problem with the Swift rules has been fixed. Note: Even though `swift_toolchain.use_all_toolchains()` also requests the C++ toolchain, adding `use_cpp_toolchain()` to that is fine; the duplication is harmless. This lets us express more explicitly "the rule depends on the Swift (and C++) toolchains, but it also uses the C++ toolchain for other things". PiperOrigin-RevId: 755951150 (cherry picked from commit 3da7b31) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
aaronsky,
adincebic,
keith,
luispadron and
mattrobmattrob
as code owners
mattrobmattrob
approved these changes
Jan 5, 2026
aaronsky
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove the explicit execution group and the workaround that disabled auto-exec-groups, because the underlying problem with the Swift rules has been fixed.
Note: Even though
swift_toolchain.use_all_toolchains()also requests the C++ toolchain, addinguse_cpp_toolchain()to that is fine; the duplication is harmless. This lets us express more explicitly "the rule depends on the Swift (and C++) toolchains, but it also uses the C++ toolchain for other things". PiperOrigin-RevId: 755951150(cherry picked from commit 3da7b31)