fix: correct misleading ORDER_HALF comment in bip-0374 #2059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment for ORDER_HALF incorrectly stated it represents "Number of valid distinct x coordinates on the curve". This is wrong - ORDER_HALF is simply half the group order, commonly used for ECDSA low-S signature normalization. The number of valid x coordinates on secp256k1 is approximately (p-1)/2 where p is the field size, which is a completely different value.
Also clarified the ORDER comment from "plus 1 for infinity" to "including infinity" for better accuracy.