fix: Respect nullable columns of tx table
#13
Merged
+35
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, reading the tx_graph ChangeSet might have failed or returned incorrect data by attempting to decode a column having a NULL value. This is fixed by introducing a `TxRow` struct with optional fields and deriving `FromRow` for it. The `txid` field is currently the only non-nullable column. Now we only parse a value and update the tx_graph ChangeSet if the column actually contains a value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, reading the
tx_graph::ChangeSetmight have failed or returned incorrect data by attempting to decode a column having aNULLvalue. This is fixed by introducing aTxRowstruct with optional fields and derivingFromRowfor it. Note thattxidfield is currently the only non-nullable column ofTxRow. Now we only parse a value and update thetx_graph::ChangeSetif the column actually contains a value.