Use focus design token on radios, checkboxes, selects#827
Open
angelikatyborska wants to merge 5 commits intomainfrom
Open
Use focus design token on radios, checkboxes, selects#827angelikatyborska wants to merge 5 commits intomainfrom
angelikatyborska wants to merge 5 commits intomainfrom
Conversation
Contributor
Author
|
See comments in #820 (comment) before reviewing |
Contributor
Author
|
Note to self: what about dialogs? dialogs are focusable Another note to self: scrollable elements can be focused in Firefox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #820
Changes
design-tokens/focusfor focus-visible styles📸 Looks like
Providing gifs because the style changes include a transition.
Select
Radio
Checkbox
How to QA
👀 Visual changes
Insert a detailed list explaining exactly how to QA your changes from a designer’s PoV
git fetchgit checkout <pr-branch-name>yarnyarn storybookCheck:
👾 Code changes
Check:
Preflight checks
PR author to check, and delete if not applicable
test/scss/have been updatedunreleasedsection of CHANGELOG.md