Skip to content

Update the ZonedDateTimeSerializer to be more lenient when deserializing#6489

Open
david-livefront wants to merge 1 commit intomainfrom
update-date-time-format
Open

Update the ZonedDateTimeSerializer to be more lenient when deserializing#6489
david-livefront wants to merge 1 commit intomainfrom
update-date-time-format

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Feb 6, 2026

🎟️ Tracking

N/A

📔 Objective

A deserialization error occurred because a ciphers password history had a date using this format: 2025-03-19T10:34:50.025+00:00

This change makes our deserialization strategy more lenient with the timezone information style.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront requested a review from a team as a code owner February 6, 2026 22:46
@david-livefront david-livefront added ai-review Request a Claude code review t:bug Change Type - Bug labels Feb 6, 2026
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context and removed ai-review Request a Claude code review t:bug Change Type - Bug labels Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Logo
Checkmarx One – Scan Summary & Details70cbd876-ff90-423a-bd2a-1d6ca1733c7e

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront david-livefront added the t:bug Change Type - Bug label Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.36%. Comparing base (ad3a9a6) to head (753eca6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6489   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files         767      767           
  Lines       56034    56034           
  Branches     8151     8151           
=======================================
  Hits        48394    48394           
  Misses       4800     4800           
  Partials     2840     2840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant