Skip to content

Fdb locking redesign#5718

Open
dorinhogea wants to merge 11 commits intobloomberg:mainfrom
dorinhogea:fdblocking
Open

Fdb locking redesign#5718
dorinhogea wants to merge 11 commits intobloomberg:mainfrom
dorinhogea:fdblocking

Conversation

@dorinhogea
Copy link
Contributor

Re-engineer fdb remote sql locking to support concurrent access to different tables and a more efficient discovery process.
Fdb is protected by a read live lock.
Each remote table is protected by a read lock as well; we use MVCC to avoid a table lock updater wait for all read locks to go away. The MVCC caches the stale tables for the duration of sqlite setup and for the duration of sqlite execution.

@dorinhogea dorinhogea added the WIP Work in Progress label Feb 6, 2026
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
recover_deadlock [core dumped]
disttxn
sc_drop
consumer_non_atomic_default_consumer_generated
unifiedcancel
remsql_rte_connect_generated
remsql_fdbpushredirect_generated
remsql_fdbpush_generated
remsql
load_remsql_rte_connect_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
recover_deadlock [core dumped]
sc_drop
consumer_non_atomic_default_consumer_generated
disttxn
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
incoh_remsql_rte_connect_generated
incoh_remsql
writes_remsql_names_rte_connect_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
recover_deadlock [core dumped]
sc_drop
consumer_non_atomic_default_consumer_generated
misstable_remsql_rte_connect_generated
misstable_remsql
disttxn
insert_lots_ssl_generated
insert_lots
incoh_remsql_rte_connect_generated
incoh_remsql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
insert_lots_ssl_generated
yast_stat4scan_generated
sp_twofiles_generated
sp_snapshot_generated
sp_queueodh_generated
sp
ixmap
analyze_recover_deadlock
autoanalyze
analyze_partial_index_off_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
incremental_backup_usenames
yast_stat4scan_generated
silogdel
sp_snapshot_generated
sp_twofiles_generated
sp
sp_queueodh_generated
ixmap
analyze_recover_deadlock
autoanalyze

@dorinhogea
Copy link
Contributor Author

/adhoc-test sp

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work in Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants