Add properties, method and template tag for showing the right name#2034
Open
0xUnicorn wants to merge 4 commits intobornhack:mainfrom
Open
Add properties, method and template tag for showing the right name#20340xUnicorn wants to merge 4 commits intobornhack:mainfrom
0xUnicorn wants to merge 4 commits intobornhack:mainfrom
Conversation
- Rename properties and change logic for showing names - Add tests for new logic in showing private/public names - Add `get_display_name` method with tests - Add a custom template tag `display_name` - Change all `get_public_credit_name` and `get_name` property calls
0xUnicorn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename properties and change logic for showing names
Add tests for new logic in showing private/public names
Add
get_display_namemethod with testsAdd a custom template tag
display_nameChange all
get_public_credit_nameandget_nameproperty callsFixes: #1944