Server crashes when an "unknown method" is called (Or "no handler" is defined).#2
Open
jensh wants to merge 3 commits intobpot:masterfrom
Open
Server crashes when an "unknown method" is called (Or "no handler" is defined).#2jensh wants to merge 3 commits intobpot:masterfrom
jensh wants to merge 3 commits intobpot:masterfrom
Conversation
With this a client can set a handler. With this a server rpc can
invoke a rpc at the client:
// rpc at the server
handler.pingpong = function(data, response) {
// invoke a rpc on the client
response.stream.invoke('pong', data, function (err, response2){
// Send response to the client
response.result(response2);
});
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch a call to an unknown method crash the server because "response" in line 97 is undefined.
Which testframework did you use for the tests in /test? I could try to write a test for this issue.