This repository was archived by the owner on Jul 31, 2020. It is now read-only.
Adding Enpoint configuration#156
Open
farfeduc wants to merge 3 commits intobrave:masterfrom
farfeduc:master
Open
Adding Enpoint configuration#156farfeduc wants to merge 3 commits intobrave:masterfrom farfeduc:master
farfeduc wants to merge 3 commits intobrave:masterfrom
farfeduc:master
Conversation
Configuration available in next commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Related issue #58
What is the goal of this PR ?
Enable users to change the AWS endpoint by changing the config files for now.
It would be better to be able change that with a simple ENV variable.
Why is this currently not complete ?
I don't know if I have to also change the tests and modify the Readme.
Maybe it would help to have a Contribution guide with coding syntax guides and Readme/tests updates guidelines ?
Do we also want this config option for the client-side too ? (I currently do not grasp how everything works).