Skip to content

Add region richmond to stable types, allow instances to be created in any region that's available #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewmalin merged 2 commits into from
Feb 18, 2026
Merged

Add region richmond to stable types, allow instances to be created in any region that's available #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
565f866
add richmond region to stable types
brianlechthaler Feb 17, 2026
e028b71
don't restrict which zones can be used, allow all zones
brianlechthaler Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions v1/providers/sfcompute/instancetype.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import (
"context"
"fmt"
"slices"
"strings"
"time"

Expand All @@ -24,8 +23,6 @@
diskTypeSSD = "ssd"
)

var allowedZones = []string{"hayesvalley", "yerba"}

func makeDefaultInstanceTypePrice(amount string, currencyCode string) currency.Amount {
instanceTypePrice, err := currency.NewAmount(amount, currencyCode)
if err != nil {
Expand Down Expand Up @@ -185,11 +182,7 @@
}

zones := make([]sfcnodes.ZoneListResponseData, 0, len(resp.Data))
for _, zone := range resp.Data {

Check failure on line 185 in v1/providers/sfcompute/instancetype.go

View workflow job for this annotation

GitHub Actions / Test and Lint 

unnecessary leading newline (whitespace)
// If the zone is not allowed, skip it
if !slices.Contains(allowedZones, strings.ToLower(zone.Name)) {
continue
}

// If the there is no available capacity, and skip it
if len(zone.AvailableCapacity) == 0 && !includeUnavailable {
Expand Down
1 change: 1 addition & 0 deletions v1/providers/sfcompute/validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ func TestValidationFunctions(t *testing.T) {
StableIDs: []v1.InstanceTypeID{
"hayesvalley-noSub-h100",
"yerba-noSub-h100",
"richmond-noSub-h100",
},
}

Expand Down
Loading