Skip to content

fix(BREV-2823): Remove hardcoded sfc locations #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drewmalin wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −11
Open

fix(BREV-2823): Remove hardcoded sfc locations #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9f66f3
Add region richmond to stable types, allow instances to be created in…
brianlechthaler Feb 18, 2026
e64755f
fix(BREV-2823): Remove hardcoded sfc locations
drewmalin Feb 18, 2026
7a85b54
remove unused locations
drewmalin Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions v1/providers/sfcompute/instancetype.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package v1
import (
"context"
"fmt"
"slices"
"strings"
"time"

Expand All @@ -24,8 +23,6 @@ const (
diskTypeSSD = "ssd"
)

var allowedZones = []string{"hayesvalley", "yerba"}

func makeDefaultInstanceTypePrice(amount string, currencyCode string) currency.Amount {
instanceTypePrice, err := currency.NewAmount(amount, currencyCode)
if err != nil {
Expand Down Expand Up @@ -186,12 +183,7 @@ func (c *SFCClient) getZones(ctx context.Context, includeUnavailable bool) ([]sf

zones := make([]sfcnodes.ZoneListResponseData, 0, len(resp.Data))
for _, zone := range resp.Data {
// If the zone is not allowed, skip it
if !slices.Contains(allowedZones, strings.ToLower(zone.Name)) {
continue
}

// If the there is no available capacity, and skip it
// If the there is no available capacity, skip it
Copy link
Contributor

@stephahart stephahart Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence still doesn't quite make sense 😆

if len(zone.AvailableCapacity) == 0 && !includeUnavailable {
continue
}
Expand Down
3 changes: 1 addition & 2 deletions v1/providers/sfcompute/validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ func TestValidationFunctions(t *testing.T) {
config := validation.ProviderConfig{
Credential: NewSFCCredential("validation-test", apiKey),
StableIDs: []v1.InstanceTypeID{
"hayesvalley-noSub-h100",
"yerba-noSub-h100",
"richmond-noSub-h100",
},
}

Expand Down
Loading