Added Touchevents and minor fix for handling click and mousedown event conflicts#130
Open
manumqln wants to merge 2 commits intobuberdds:masterfrom
Open
Added Touchevents and minor fix for handling click and mousedown event conflicts#130manumqln wants to merge 2 commits intobuberdds:masterfrom
manumqln wants to merge 2 commits intobuberdds:masterfrom
Conversation
|
Hi @manumqln - I tried your branch and it did not resolve the issue with the 'colorpicker-selected' event on click. The event still only contains the correct data on drag but not on click. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library can now be used in touch enabled devices to select colour by dragging pickers using touch. There was a minor glitch in the library which does not invoke 'colorpicker-selected' event while clicking on the picker saturation, hue or alpha. This was also fixed.