feat: preliminary support for WIT templates#964
Draft
dicej wants to merge 1 commit intobytecodealliance:mainfrom
Draft
feat: preliminary support for WIT templates#964dicej wants to merge 1 commit intobytecodealliance:mainfrom
dicej wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
| } | ||
| let func = self.resolve_function(&value.docs, value.name(), func)?; | ||
| let prev = if matches!(value.name, VariableId::Wildcard(_)) { | ||
| self.interfaces[interface_id].wildcard.replace(func) |
Contributor
There was a problem hiding this comment.
I think we'll want to handle prev.is_some() (indicating multiple * appears textually) here and return a concrete syntax error positioned at the span of the wildcard.
This is a minimum viable implementation of WIT templates per WebAssembly/component-model#172. It supports interfaces with at most one wildcard function, which may be expanded (i.e. monomorphized) with a set of substitutions provided by the application developer when generating guest bindings. I will be posting separate PRs to the `wit-bindgen` and `wasmtime` repos to implement and test guest and host binding generation, respectively. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimum viable implementation of WIT templates per WebAssembly/component-model#172. It supports interfaces with at most one wildcard function, which may be expanded (i.e. monomorphized) with a set of substitutions provided by the application developer when generating guest bindings. I will be posting separate PRs to the
wit-bindgenandwasmtimerepos to implement and test guest and host binding generation, respectively.