Exception and control tags#10251
Merged
alexcrichton merged 7 commits intobytecodealliance:mainfrom Feb 20, 2025
Merged
Conversation
This was referenced Feb 20, 2025
github-actions
bot
added
fuzzing
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:c-api", "wasmtime:config", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Feb 20, 2025
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thank you again for being willing to split up the PR, it's very helpful!
Comment on lines
+1085
to
+1088
| // FIXME(dhil): Once the config provides a handle | ||
| // for turning on/off exception handling proposal support, | ||
| // this ought to only enable stack switching. | ||
| self.wasm_feature( |
Member
There was a problem hiding this comment.
I added a "miscellaneous TODO items" section on #10248 and added this there too (trying to ensure FIXME's like this are written down in issues)
Contributor
Author
My pleasure! Thanks! |
fitzgen
reviewed
Feb 26, 2025
fitzgen
reviewed
Feb 26, 2025
fitzgen
reviewed
Feb 26, 2025
fitzgen
reviewed
Feb 26, 2025
tanishiking
added a commit
to tanishiking/jco
that referenced
this pull request
Apr 4, 2025
wasmtime-environ 31.0.0 adds support for exception tags. bytecodealliance/wasmtime#10251 Previously, exception tags were not supported, and attempting to transpile a component module containing a tag would fail by hitting `unreachable`. Updating `wasmtime-environ` to 31.0.0 enable to transpile binary with exceptions.
vados-cosmonic
pushed a commit
to bytecodealliance/jco
that referenced
this pull request
Apr 6, 2025
wasmtime-environ 31.0.0 adds support for exception tags. bytecodealliance/wasmtime#10251 Previously, exception tags were not supported, and attempting to transpile a component module containing a tag would fail by hitting `unreachable`. Updating `wasmtime-environ` to 31.0.0 enable to transpile binary with exceptions.
This was referenced Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is a subset of PR #10177. It adds support for tags in Wasmtime. Tags are used by the exception handling and stack switching proposals for typing and matching transfers of control.
This patch does not implement component model or C API support for tags. Issue #10252 tracks these two things.
CC @frank-emrich