Open
Conversation
created delete api to delete respected bank account
created and implemented bank account table to display any bank accounts created
created bank account modal and implemented input fields based on respected prisma bank account schema
created bank account create api to take in values from input fields and send data to db into bankAccount table and implemented audit function
…k and Block are not compatiable
updated delete feature content to reflect bank account action
updated bank account notification, onSuccesseful deletion will return server message with toast message
updated bank account delete and create api to return a message on 200 return
updated created api with try catch block with custom error when @@unique runs
updated bank account modal notification to catch custom @@unique from server
created edit bank account functionality to allow user to update information for respected bank acccount created new edit bank account modal to separate original create bank account modal updated audit schema to include update when user successfully updates an account created update api to update bank account based on id
updated primary account logic to show confirm diaglog box which if then user confirm, this allows the user to switch primary account and if cancelled, switch button is still disabled until confirmed
removed @@unique constraint on primary column as this would result in error when trying to switch account false -> true and true -> false
created migration on prisma db to remove @@unique constraints on companyId and primary to allow auto switch on primary accounts from false -> true and true -> false
updated edit bank account feature to allow user to edit any info needed and updated respected account based on field clicked and taking care of if user is switching primary accounts
running a findFirst on both primary and nonPrimary and if new bankAccount being created is with wanted primary account and findFirst query returns true as well then error is passed down and bank account is not created but if there is not then bank account can be created
when user successfully creates bank account modal disappears and user is shown newly created accounts
remove un-needed value - token
|
Thank you for following the naming conventions for pull request titles! 🙏 |
Contributor
Author
|
Note: After merging main into this Alfredoeb9:add_bank_account_screen I'm seeing error on ./src/emails/AccountVerificationEmail.tsx
Steps Taken: I then checked out main branch without my changes on this PR branch and seeing same errors as above. I can confirm errors on screenshot are not coming from Alfredoeb9:add_bank_account_screen but have to be coming from a different PR that was merged in prior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #452
This PR implements the new feature to allow users to create, read, update and delete bank accounts.
Build test has passed.