feat: add server side pagination and filteration#503
Open
Conversation
|
Thank you for following the naming conventions for pull request titles! 🙏 |
G3root
commented
Sep 2, 2024
| "@tanstack/react-table": "^8.20.1", | ||
| "@tremor/react": "^3.17.4", | ||
| "@trpc/client": "^10.43.6", | ||
| "@trpc/next": "^10.45.2", |
Collaborator
Author
There was a problem hiding this comment.
upgraded to trpc 11 to useSuspenseQuery from "@tanstack/react-query". useSuspenseQuery is introduced in "@tanstack/react-query v5 upgrading only this package breaks trpc
dahal
requested changes
Sep 16, 2024
Contributor
dahal
left a comment
dahal
left a comment
There was a problem hiding this comment.
Great job on this PR @G3root . Here are few things I found
- Search on stakeholder table does not work.
- Lets implement full text search, and allow search by name or email using this
- When i search or paginate to next page, the page flashes, we prolly need some sort of transition to make it load smoothly.
Collaborator
Author
|
@dahal pushed some changes |
Collaborator
Author
|
contains api finding better results than the full-text-search one 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.