Add createFile param to the switch submode command #3867
Conversation
Preview deployments |
…h-ai-it-will-sometimes
jurgenwerk
force-pushed
the
cs-9640-when-trying-to-create-a-new-card-with-ai-it-will-sometimes
branch
from
76b1b4d to
2cbf92e
Compare
There was a problem hiding this comment.
Pull request overview
This PR enhances the AI assistant's user experience by adding a createFile parameter to the switch-submode command. When switching from interact mode to code mode, the assistant can now create a blank file immediately, allowing users to see an empty file instead of an index card while the AI generates code.
Changes:
- Added
createFileboolean parameter toSwitchSubmodeInputand introducedSwitchSubmodeResultcard definition for handling filename conflicts - Implemented file creation logic in switch-submode command with automatic conflict resolution when target files already exist
- Extracted filename conflict resolution logic to a reusable utility function and refactored patch-code command to use it
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/base/command.gts | Added createFile field to SwitchSubmodeInput and defined SwitchSubmodeResult card for communicating filename changes |
| packages/host/app/commands/switch-submode.ts | Implemented file creation logic with conflict resolution when switching from interact to code mode |
| packages/host/app/utils/file-name.ts | New utility function for finding non-conflicting filenames |
| packages/host/app/commands/patch-code.ts | Refactored to use shared filename conflict resolution utility |
| packages/runtime-common/ai/prompt.ts | Added instruction generation for AI when filename conflicts occur |
| packages/host/app/components/matrix/room-message-command.gts | Hide result cards for switch-submode commands in the UI |
| packages/host/tests/integration/commands/switch-submode-test.gts | Added tests for file creation and conflict resolution scenarios |
| packages/ai-bot/tests/prompt-construction-test.ts | Added test for AI instruction when filename conflicts occur |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jurgenwerk
changed the title
…h-ai-it-will-sometimes
|
Accompanying PR: cardstack/boxel-skills#44 |
| let { status, content } = await this.cardService.getSource(codeUrl); | ||
| if (status === 404) { | ||
| await this.cardService.saveSource(codeUrl, '', 'create-file'); | ||
| } else if (status === 200) { | ||
| if (content.trim() !== '') { | ||
| let nonConflictingUrl = await findNonConflictingFilename( | ||
| codeUrl.href, | ||
| (candidateUrl) => this.fileExists(candidateUrl), | ||
| ); | ||
| let newCodeUrl = new URL(nonConflictingUrl); | ||
| await this.cardService.saveSource(newCodeUrl, '', 'create-file'); | ||
| finalCodeUrl = newCodeUrl; | ||
|
|
There was a problem hiding this comment.
It might be elegant to delegate to a separate command to accomplish this.
There was a problem hiding this comment.
I'll check if I can use WriteTextFileCommand for this
There was a problem hiding this comment.
I adjusted WriteTextFileCommand to fit this case and used it in this command
packages/runtime-common/ai/prompt.ts
Outdated
| content = [content, switchSubmodeInstruction] | ||
| .filter(Boolean) | ||
| .join('\n\n'); | ||
| } |
There was a problem hiding this comment.
I'm not enthusiastic about having command-specific code in the ai prompt generation. Is this necessary?
There was a problem hiding this comment.
My intent was to not add more text to the skills prompt since this should be a rare case. I checked and we can achieve this by adding a line to the development skill and drop this new logic in the ai bot
There was a problem hiding this comment.
Ai bot logic removed, and I added some extra instructions in the development skill: cardstack/boxel-skills@2719575#r2721123671
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
jurgenwerk
force-pushed
the
cs-9640-when-trying-to-create-a-new-card-with-ai-it-will-sometimes
branch
from
5084d41 to
8bee425
Compare
This PR addresses a user experience issue where:
This PR adds an optional boolean param
createFileto switch mode command where it will create the file the assistant is about to generate. The user will be transitioned to code mode, seeing a blank file until the AI assistant is done generating the code.The changes in this PR alone don't fix the mentioned issue yet - there will be another PR in the skills repo to teach the LLM when to use
createFileparameter (I have it almost ready and confirm it works with all of the above).Note
Introduces a file-creation path when switching to code mode and centralizes non-conflicting filename handling.
createFiletoSwitchSubmodeInputand newSwitchSubmodeResult; creates an empty file on switch from interact→code when requested, reusing blank files or picking a non-conflicting filename; updates UI to not render result cards forswitch-submodecommandsWriteTextFileCommandto returnFileUrlCard, supportuseNonConflictingFilename, useCardService.saveSource, and avoid overwriting existing content unless requestedutils/file-name.tsand updatespatch-codeto use it when inserting into non-empty filesWritten by Cursor Bugbot for commit 8bee425. This will update automatically on new commits. Configure here.