Open
Conversation
Author
|
I just figured out that inserts and updates are removing decimal places and entering the "longValue" also. So, I'm working on that now. |
Owner
|
@lbecker34 I have not had a ton of time to work on this but there is an active PR that you may want to look at too that changes the return style (was going to be a v2 style update) |
Author
|
@cbschuld Is there still value in me doing this then? When do you think that other PR will be done? I can still try and fix the bug where decimals are being rounded down to the whole number on update too. |
Author
|
@cbschuld This PR is now ready to go. I fixed the bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change adds decimal support. Response for a decimal column from the AWS SDK is the following. Decimal columns are returned with a "stringValue" property.
{ "columnMetadata": [{ "arrayBaseColumnType": 0, "isAutoIncrement": false, "isCaseSensitive": false, "isCurrency": false, "isSigned": false, "label": "account", "name": "account", "nullable": 0, "precision": 100, "scale": 0, "schemaName": "", "tableName": "Movements", "type": 12, "typeName": "VARCHAR" }, { "arrayBaseColumnType": 0, "isAutoIncrement": false, "isCaseSensitive": true, "isCurrency": false, "isSigned": true, "label": "functional_amount", "name": "functional_amount", "nullable": 0, "precision": 27, "scale": 8, "schemaName": "", "tableName": "Movements", "type": 3, "typeName": "DECIMAL" }, { "arrayBaseColumnType": 0, "isAutoIncrement": false, "isCaseSensitive": true, "isCurrency": false, "isSigned": true, "label": "transaction_amount", "name": "transaction_amount", "nullable": 0, "precision": 27, "scale": 8, "schemaName": "", "tableName": "Movements", "type": 3, "typeName": "DECIMAL" } ], "numberOfRecordsUpdated": 0, "records": [ [{ "stringValue": "account" }, { "stringValue": "100.00000000" }, { "stringValue": "100.00000000" } ] ] }