feat: improve index and show partners pages design#542
Open
feat: improve index and show partners pages design#542
Conversation
1 task
Member
|
I also suggest we delay this a bit since #538 is about to be merged and can be used on this page ! 🙌 |
Co-authored-by: Mário Rodrigues <93675410+MarioRodrigues10@users.noreply.github.com>
MarioRodrigues10
requested changes
Feb 28, 2025
Member
|
Please also solve the conflicts ! |
AfonsoMartins26
requested changes
Jul 1, 2025
Contributor
AfonsoMartins26
left a comment
There was a problem hiding this comment.
ou need to merge with develop, and then update the image uploader in partner_live/form_component.ex to use the new format. Replace the existing component:
<.live_component module={ImageUploader} id="uploader" uploads={@uploads} target={@myself} />to this:
<.image_uploader id="uploader" upload={@uploads.image} class="h-32 w-full border border-zinc-300 shadow-sm xl:h-64" image_class="h-32 w-full object-cover xl:h-64" />Once that’s done, everything should work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Improve the design of both show and index partners pages index
TODO:
FIX: