support (nongenerative uid) in define-ftype#1015
Open
mflatt wants to merge 1 commit intocisco:mainfrom
Open
Conversation
jltaylor-us
reviewed
Feb 7, 2026
A `(nongenerative uid)` clause in `define-ftype` is analogous to the same kind of clause in `define-record-type`. To prevent mismatched definitions using the same `uid` the check for interned record types needs to compare "extras" --- fields that are added to the record type itself. Previously, "extras" were just assumed to be the same, since they were only generated internally. Also, correct some information in the documentation about the generativity of `define-ftype`. When the right-hand side is an existing ftype name, the definition is not syntactically generative. In those case, `(nongenerative uid)` is disllowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
(nongenerative uid)clause indefine-ftypeis analogous to the same kind of clause indefine-record-type.To prevent mismatched definitions using the same
uidthe check for interned record types needs to compare "extras" —fields that are added to the record type itself. Previously, "extras" were just assumed to be the same, since they were only generated internally.Also, correct some information in the documentation about the generativity of
define-ftype. When the right-hand side is an existing ftype name, the definition is not syntactically generative. In those case,(nongenerative uid)is disllowed.