Extended semver.sh to also work as a stand alone command + rewritten tests#3
Open
StevenLooman wants to merge 9 commits intocloudflare:masterfrom
Open
Extended semver.sh to also work as a stand alone command + rewritten tests#3StevenLooman wants to merge 9 commits intocloudflare:masterfrom
StevenLooman wants to merge 9 commits intocloudflare:masterfrom
Conversation
|
This is exactly what I was looking for -- thank you @StevenLooman !! Note to maintainers: You've got some outstanding pull requests. I recommend pulling this one in, at least. |
|
@perplexes @StevenLooman it fails FAIL./semver.sh 1.0.0-rc.1 gt 1.0.0-rc.0
./semver.sh: line 38: [: 1.1: integer expression expected
./semver.sh: line 42: [: 1.1: integer expression expected
./semver.sh: line 47: [: 0.1: integer expression expected
./semver.sh: line 51: [: 0.1: integer expression expected
./semver.sh: line 56: [: 0.1: integer expression expected
./semver.sh: line 60: [: 0.1: integer expression expected
0tested under OSX I created a similar tool simplified way that actually works as intended https://gist.github.com/Ariel-Rodriguez/9e3c2163f4644d7a389759b224bfe7f3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended semver.sh to also work as a stand alone command. Now one can do:
Also, reimplemented the tests to make it easier to spot errors.