Open
Conversation
| val newGrad = grad(i)(j) / (math.sqrt(his(i)(j)) + eps) | ||
| if(newGrad != 0.0) { | ||
| factors(i)(j) -= stepSize * (newGrad + factors(i)(j) * regParamL2) | ||
| if(shrinkageVal > 0) { |
Contributor
|
似乎有一些bug ,我跑的结果不太对: |
Contributor
|
Haipeng, would you please take a look? Get Outlook for iOS On Sat, Aug 13, 2016 at 10:07 PM -0700, "Guoqiang Li" notifications@github.com wrote: 似乎有一些bug ,我跑的结果不太对: You are receiving this because you are subscribed to this thread. |
| extDataSet.count() | ||
|
|
||
| def run(iterations: Int): Unit = { | ||
| var his = Array.fill(featureSize + views.length, rank)(0.0) |
Contributor
There was a problem hiding this comment.
可以移到外面.放到类里面像这样:
@transient private lazy val his = Array.fill(featureSize + views.length, rank)(0D)
Contributor
|
可以看下我测试的分支: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.