Fix download URL retrieval for Linux #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
eandersons
force-pushed
the
Fix-Linux-download-URL-retrieval
branch
from
58c4a5f to
2181da8
Compare
eandersons
force-pushed
the
Fix-Linux-download-URL-retrieval
branch
from
2181da8 to
c16cff0
Compare
The function `fetch_latest_version` was updated to correctly retrieve the architecture specific download URL from a release info response.
eandersons
force-pushed
the
Fix-Linux-download-URL-retrieval
branch
from
c16cff0 to
81b031d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
fetch_latest_versionwas updated to correctly retrieve the architecture specific download URL from a release info response.It appears that the previous solution was based on the assumption that each URL in the response JSON would be in its own line, but for now the whole response is in a single line. My proposed solution works for both single-line and multi-line JSON response.
It should be noted that the regular expression
[[:alnum:]:/.-]\+used with sed will cause the script to fail in case the download URLs will contain some other characters than digits, letters, colon (:), slash (/), dot (.) and hyphen (-).Probably a better alternative would be to use the regular expression
[^\"]\+to match every character except double quotes (") which are unlikely to be used for download URLs.A bit simpler and more reliable solution would be to use jq (for example:
jq .linux_x64), but that unfortunately would also be an additional dependency since not all systems have jq installed by default.