This repository was archived by the owner on Mar 26, 2025. It is now read-only.
Handle errors of parsing JSON response.#30
Open
cpavlo wants to merge 1 commit intocoinbase:masterfrom
Open
Conversation
Contributor
|
Hey @cpavlo thanks for the revision, could you do this with the promise library included in package.json, until we have babel transcribe es6 syntax? Just to keep it compatible with older versions of node. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your library has a problem when a response from coinbase service is not JSON in case of error. Then promises from your library are not rejected and this causes an uncaught exception in Node.js application. Here is a fix for the problem.