-
Notifications
You must be signed in to change notification settings - Fork 34
feat: Adding settings, utils, write to S3, and writer close #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 95.78% 97.05% +1.27%
==========================================
Files 7 9 +2
Lines 877 918 +41
==========================================
+ Hits 840 891 +51
+ Misses 37 27 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Given that the test coverage check fails on this one, what about adjusting the coverage check to a fixed value instead of the last coverage value? |
|
While the coverage check failed, I don't think it will cause a problem in the next CI run? It's just a slightly easier hurdle next time. |
I added additional unit tests which should increase the coverage above the threshold. However, codecov seemed to stopped working after moving the repo to the CC org. I already requested access to the org. I guess you just need to approved codecov again @wumpus. |
This PR integrates a couple of general changes from the EOT PR (#54):
settings.pyutils.pywriter.close()statement is added to CLI and example.