Skip to content

docs: fix NodeBin docstring to reflect accepted drag types#622

Merged
jthrilly merged 2 commits intopedigree-stablefrom
copilot/sub-pr-619
Feb 10, 2026
Merged

docs: fix NodeBin docstring to reflect accepted drag types#622
jthrilly merged 2 commits intopedigree-stablefrom
copilot/sub-pr-619

Conversation

Copy link
Contributor

Copilot AI commented Feb 10, 2026

The NodeBin component's docstring incorrectly stated it only accepts EXISTING_NODE drag types, while the implementation accepts both EXISTING_NODE and FAMILY_TREE_NODE.

Changes

  • Updated JSDoc comment to document both accepted drag-and-drop types
/**
 * Renders a droppable NodeBin which accepts `EXISTING_NODE` and `FAMILY_TREE_NODE`.
 */
const NodeBin = ({ accepts, dropHandler }: NodeBinProps) => {
  const { dropProps, isOver, willAccept } = useDropTarget({
    id: 'node-bin',
    accepts: ['EXISTING_NODE', 'FAMILY_TREE_NODE'],
    // ...
  });
  // ...
};

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fresco-sandbox Canceled Canceled Feb 10, 2026 4:33pm

Request Review

Co-authored-by: jthrilly <1387940+jthrilly@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from review on previous pull request docs: fix NodeBin docstring to reflect accepted drag types Feb 10, 2026
Copilot AI requested a review from jthrilly February 10, 2026 16:30
@jthrilly jthrilly marked this pull request as ready for review February 10, 2026 16:32
Copilot AI review requested due to automatic review settings February 10, 2026 16:32
@jthrilly jthrilly merged commit ccd4c4a into pedigree-stable Feb 10, 2026
1 of 2 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates NodeBin’s JSDoc to accurately reflect the drag-and-drop types the component actually accepts, aligning documentation with the current useDropTarget configuration.

Changes:

  • Updated NodeBin JSDoc to state it accepts both EXISTING_NODE and FAMILY_TREE_NODE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants