Conversation
mikhailChelbaev
requested changes
Feb 5, 2025
Collaborator
mikhailChelbaev
left a comment
mikhailChelbaev
left a comment
There was a problem hiding this comment.
It works well but the code is very complicated.
Refactor using only one layer for a remaining part of the progress.
Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/CircularProgressPreview.swift
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
- onValueChange deleted - labelConstraints deleted
- progressLabel renamed to label - style extracted into style helper
- added stripesMaskLayer - func updateStripesPath deleted, logic extracted into updateShapePaths
mikhailChelbaev
requested changes
Feb 7, 2025
Sources/ComponentsKit/Components/CircularProgress/Models/CircularProgressVM.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Show resolved
Hide resolved
Sources/ComponentsKit/Components/CircularProgress/UKCircularProgress.swift
Outdated
Show resolved
Hide resolved
- update only stripesMaskLayer - added isStripesLayerHidden
- added isBackgroundLayerHidden
- stroke values and label text inside the setup method
mikhailChelbaev
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.