Skip to content

Use superview's width in fullwidth components only when it's greater than 0 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikhailChelbaev merged 1 commit into from
Feb 11, 2025
Merged

Use superview's width in fullwidth components only when it's greater than 0 #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sources/ComponentsKit/Components/ProgressBar/UKProgressBar.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,13 @@ open class UKProgressBar: UIView, UKComponent {
// MARK: - UIView methods

open override func sizeThatFits(_ size: CGSize) -> CGSize {
let width = self.superview?.bounds.width ?? size.width
let width: CGFloat
if let parentWidth = self.superview?.bounds.width,
parentWidth > 0 {
width = parentWidth
} else {
width = 10_000
}
return CGSize(
width: min(size.width, width),
height: min(size.height, self.model.backgroundHeight)
Expand Down
8 changes: 7 additions & 1 deletion Sources/ComponentsKit/Components/Slider/UKSlider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,13 @@ open class UKSlider: UIView, UKComponent {
// MARK: - UIView Methods

open override func sizeThatFits(_ size: CGSize) -> CGSize {
let width = self.superview?.bounds.width ?? size.width
let width: CGFloat
if let parentWidth = self.superview?.bounds.width,
parentWidth > 0 {
width = parentWidth
} else {
width = 10_000
}
return CGSize(
width: min(size.width, width),
height: min(size.height, self.model.handleSize.height)
Expand Down