Add RtActivatable::can_be_registered method#87
Open
GuillaumeGomez wants to merge 1 commit intocontextfree:masterfrom
Open
Add RtActivatable::can_be_registered method#87GuillaumeGomez wants to merge 1 commit intocontextfree:masterfrom
GuillaumeGomez wants to merge 1 commit intocontextfree:masterfrom
Conversation
GuillaumeGomez
force-pushed
the
can-be-registered
branch
from
687f099 to
2498109
Compare
Collaborator
|
I'm sorry that I didn't answer earlier, but the reason is that I'm currently not actively developing this project because https://kennykerr.ca/2020/02/22/rust-winrt-coming-soon/ is a thing. In principle, this PR looks good and I could as well just merge it, but I don't know if that would help anyone if I don't also eventually make a new release, which I'm currently not planning to do. |
Author
|
No problem, if the issue is solved in the long run, I'm fine with it. But being able to check if you can use something beforehand to prevent unwanted panics is a must have for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I get a panic at runtime(!) in GuillaumeGomez/sysinfo#287 because we can't check beforehand if we can use an interface or not. I think this is not great and added this method to allow me to check so I can avoid the panic.
This is just an example, if you have a better solution, I'll all for it!