update service load balancer feature document by g1rana · Pull Request #165 · contiv/contiv.github.io

g1rana · 2017-08-22T19:42:17Z

Add section to configure service load balancer using netctl

dseevr · 2017-08-22T21:17:33Z

websrc/source/documents/networking/services.md

 - Minimal downtime.

 A provider is one or more containers that match the label selector associated with the services.
+ **Note**: This feature would be deprecated since docker 1.12 onword service load balancer feature  is supported natively by docker swarm. 


onword -> onward

dseevr · 2017-08-22T21:18:22Z

websrc/source/documents/networking/services.md

 that group providers with matching labels. 

-To create a Service Load Balancer using the UI:
+###To create a Service Load Balancer using netctl:


A space is required after ### so it shows up as a heading properly

dseevr · 2017-08-22T21:18:52Z

websrc/source/documents/networking/services.md

-To create a Service Load Balancer using the UI:
+###To create a Service Load Balancer using netctl:
+
+1\. Create newtwork as net0-2 in tenant default


newtwork -> network

"tenant default" sounds weird... I'd change these three to say "default tenant"

Sure, will change it

dseevr · 2017-08-22T21:21:20Z

websrc/source/documents/networking/services.md

+	netctl service create svc-0-default --network svc-net-2-0 -t default --selector=key0=value1 --selector=key1=value2 --selector=key2=value3 --selector=key3=value4 --port=80:8080:TCP --port=643:7070:UDP
+
+
+After above operation, check service IPs , using _netctl service inspect <service name>_. In this example, service  Ips is 30.2.0.1 


Use a single backtick before and after the command to highlight it like this

Please remove the extraneous comma: "IPs , using" -> "IPs using"

Using backtick will break format consistence in the document page.

dseevr · 2017-08-22T21:21:41Z

websrc/source/documents/networking/services.md

+
+After above operation, check service IPs , using _netctl service inspect <service name>_. In this example, service  Ips is 30.2.0.1 
+
+````


Blocks only use three backticks, not four

Ok . rearrange format now.

dseevr · 2017-08-22T21:24:17Z

websrc/source/documents/networking/services.md

+    docker exec -it net0-2-srv2-2-2  nc -z -n -v -w 1  30.2.0.1 80
+    docker exec -it net0-2-srv0-0-0  nc -z -n -v -w 1  30.2.0.1 80
+
+8.\  As above operation result, client utiltiy  must be connected to the service 


I'm not sure what this sentence is trying to say. What is the "client utility"? Why is there no text under this step?

"utiltiy" -> "utility"

I think , you are right . this sentence shouldn't be exist. docker exec operation itself explain the outcome. removing the sentence now

dseevr · 2017-08-22T21:24:26Z

websrc/source/documents/networking/services.md

+
+
+
+###To create a Service Load Balancer using the UI:


Add a space after ###

dseevr · 2017-08-22T21:25:33Z

Don't forget to run make in the websrc directory to generate the static files and then commit them, too.

Please see: https://github.com/contiv/contiv.github.io/blob/6ef851da93c6ae22cc99057c639a308801e7932f/CONTRIBUTING.md#submitting-changes

dseevr · 2017-08-28T17:39:33Z

The changes look fine, but could you merge all these commits into one using git rebase -i? Lemme know if you need help with that

dseevr · 2017-09-21T06:36:12Z

Actually, I can just have these combined into one commit when I merge it lol

@g1rana is this ready to go or are there more changes to be made?

dseevr · 2017-10-31T00:16:47Z

@g1rana do we still want to merge this?

To resolve the conflict, just delete sitemap.xml on your branch, rebase against the latest changes on master, then re-run make and commit everything

update service loadbalancer feature document

e29d3f6

dseevr requested changes Aug 22, 2017

View reviewed changes

Jeewan Rana added 2 commits August 25, 2017 14:35

incorporate review comments

2676efd

incorporate review comments

d05e8c6

dseevr approved these changes Aug 28, 2017

View reviewed changes

		netctl service create svc-0-default --network svc-net-2-0 -t default --selector=key0=value1 --selector=key1=value2 --selector=key2=value3 --selector=key3=value4 --port=80:8080:TCP --port=643:7070:UDP


		After above operation, check service IPs , using _netctl service inspect <service name>_. In this example, service Ips is 30.2.0.1


		After above operation, check service IPs , using _netctl service inspect <service name>_. In this example, service Ips is 30.2.0.1

		````

Conversation

g1rana commented Aug 22, 2017

Uh oh!

dseevr Aug 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

g1rana Aug 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dseevr commented Aug 22, 2017

Uh oh!

dseevr commented Aug 28, 2017

Uh oh!

dseevr commented Sep 21, 2017

Uh oh!

dseevr commented Oct 31, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dseevr Aug 22, 2017 •

edited

Loading

g1rana Aug 25, 2017 •

edited

Loading