Add entry for Sujay Dongre in CLA signers #414
Conversation
📝 WalkthroughWalkthroughA new contributor CLA (Contributor License Agreement) signer entry is added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Pull request overview
This PR attempts to add Sujay Dongre as a CLA signer to the .github/cla-signers.json file to close issue #413. However, this creates a critical duplicate entry issue.
Key Issue:
- The entry being added duplicates an existing CLA signer record (lines 37-43) for the same person with identical GitHub username and email
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| { | ||
| "name": "Sujay Dongre", | ||
| "github_username": "sujay-d07", | ||
| "emails": [ | ||
| "sujaydongre07@gmail.com" | ||
| ], | ||
| "signed_date": "2026-01-01", | ||
| "cla_version": "1.0" |
There was a problem hiding this comment.
This entry for Sujay Dongre is a duplicate. The same person with the same GitHub username (sujay-d07) and email (sujaydongre07@gmail.com) already exists in the CLA signers list at lines 37-43 with a signed date of "2024-12-29". Adding this duplicate entry will cause issues with CLA validation. Please remove this duplicate entry.
| }, | |
| { | |
| "name": "Sujay Dongre", | |
| "github_username": "sujay-d07", | |
| "emails": [ | |
| "sujaydongre07@gmail.com" | |
| ], | |
| "signed_date": "2026-01-01", | |
| "cla_version": "1.0" |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/cla-signers.json (1)
3-3: Update thelast_updatedfield to reflect the current modification.The
last_updatedfield shows "2025-12-31" but entries with a signed_date of "2026-01-01" are being added. This field should be updated to reflect when the file was last modified.🔎 Proposed fix
- "last_updated": "2025-12-31", + "last_updated": "2026-01-01",
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/cla-signers.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build Package
- GitHub Check: test (3.10)
- GitHub Check: test (3.12)
- GitHub Check: test (3.11)
| { | ||
| "name": "Sujay Dongre", | ||
| "github_username": "sujay-d07", | ||
| "emails": [ | ||
| "sujaydongre07@gmail.com" | ||
| ], | ||
| "signed_date": "2026-01-01", | ||
| "cla_version": "1.0" | ||
| } |
There was a problem hiding this comment.
Critical: Duplicate entry for the same individual.
An entry for Sujay Dongre (github_username: sujay-d07, email: sujaydongre07@gmail.com) already exists at lines 37-44 with a signed_date of "2024-12-29". Adding a second entry creates a duplicate record, which violates data integrity for a CLA signers registry.
If the contributor needs to re-sign with an updated date, update the existing entry's signed_date field instead of creating a duplicate.
🔎 Proposed fix: Update existing entry instead of adding duplicate
Remove the new duplicate entry (lines 72-80) and update the existing entry's signed_date:
"signed_date": "2025-12-31",
"cla_version": "1.0"
- },
- {
- "name": "Sujay Dongre",
- "github_username": "sujay-d07",
- "emails": [
- "sujaydongre07@gmail.com"
- ],
- "signed_date": "2026-01-01",
- "cla_version": "1.0"
}
],And update the existing entry at lines 37-44:
{
"name": "Sujay Dongre",
"github_username": "sujay-d07",
"emails": [
"sujaydongre07@gmail.com"
],
- "signed_date": "2024-12-29",
+ "signed_date": "2026-01-01",
"cla_version": "1.0"
},Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
.github/cla-signers.json lines 72-80 contain a duplicate entry for Sujay Dongre
(github_username: "sujay-d07", email: "sujaydongre07@gmail.com") which already
exists at lines 37-44; remove the duplicate block at lines 72-80 and update the
existing entry at lines 37-44 by setting its signed_date to "2026-01-01" (or the
new intended date) instead of adding a new record.
|
@sujay-d07 No need to raise a PR again, will fix soon the CLA issues. |
2 participants
Related Issue
Closes #413
Summary
Signing the CLA
Checklist
pytest tests/)Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.