Update Ruler frontend_address comments to mention Store Gateway #7179
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kishore K G <kishorekg@google.com>
kishorekg1999
force-pushed
the
ruler-doc
branch
from
9abc1a4 to
e18e8b8
Compare
SungJin1212
reviewed
Dec 30, 2025
Co-authored-by: SungJin1212 <tjdwls1201@gmail.com> Signed-off-by: kishorekg1999 <kishorekg.github@gmail.com>
Author
|
@SungJin1212 the integration tests have been failing. Are those tests flaky ? Is there a way to get an exception ? |
Member
yeah, the query fuzz test is flaky now. can you run |
Signed-off-by: Kishore K G <kishorekg@google.com>
kishorekg1999
force-pushed
the
ruler-doc
branch
from
30ff3dd to
a52983f
Compare
Signed-off-by: Kishore K G <kishorekg@google.com>
Author
|
@SungJin1212 can you please approve the workflow ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
pdates the documentation and code comments for the Ruler's frontend_address configuration to accurately reflect that the Ruler queries both Ingesters and Store Gateways directly when frontend_address is not configured. Previously, the comments incorrectly stated it only queried Ingesters.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]