ShieldTrigger and StripTrigger #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to update m_ShieldPanelGroups for future and test the deadtime.
Updated BGO detector names from 1 back to 0.
- ACS detectors now ACS_X0_0, ACS_X0_1, ACS_X1_0, etc. - GeD detectors now GeD_0, GeD_2 etc.
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 21, 2026
zoglauer
reviewed
Jan 28, 2026
| // protected members: | ||
| protected: | ||
| unsigned int m_DetectorID; //!< Detector ID | ||
| MString m_DetectorID; //!< Detector ID |
Collaborator
There was a problem hiding this comment.
Could you do the normal documentation scheme which we use everywhere else
//! Detector ID as string, e.g. ...
MString m_DetectorID
Same below
zoglauer
reviewed
Jan 28, 2026
|
|
||
| //! Setters and getters | ||
| void SetDetectorID(unsigned int DetectorID) | ||
| void SetDetectorID(MString DetectorID) |
Collaborator
There was a problem hiding this comment.
To make the it read better in doxygen, please document each function individually, even if it is trivial
zoglauer
reviewed
Jan 28, 2026
| MTime m_DeadTimeEnd; | ||
|
|
||
|
|
||
| // Shield parameters |
Collaborator
There was a problem hiding this comment.
Document each parameter please
zoglauer
reviewed
Jan 28, 2026
| //! Number of shield panels | ||
| static const int nShieldPanels = 6; | ||
|
|
||
| vector<double> m_ShieldLastHitTime; |
Collaborator
There was a problem hiding this comment.
Above and below: Document everything please
zoglauer
reviewed
Jan 28, 2026
| //! Total strip delay after readout | ||
| double m_StripDelayAfter; | ||
|
|
||
| double m_StripCoincidenceWindowFromFile; |
Collaborator
There was a problem hiding this comment.
Document everything please
zoglauer
reviewed
Jan 28, 2026
| int m_TotalStripHitsCounter; | ||
|
|
||
| //! First and last event times | ||
| double m_FirstTime; |
Collaborator
There was a problem hiding this comment.
Document each variable individually
Collaborator
|
Just minor documentation changed are left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShieldTrigger and StripTrigger updated with ASIC and ADC dead time. Changed GeD names to GeD_0, GeD_1 ... and BGO to ACS_X0_0, ACS_X0_1, ACS_X1_0, ACS_X1_1 ...
Still need to add GR vetoes, dead strips, trigger thresholds for both shields and strips and possible telemetry dead time.
ACS energy correction commented out for now. @vfioretti will update and add it back in.