Open
Conversation
Per tal que sigui compatible amb PHP 5.6, s'han fet els següents canvis:
1. La funció end sobre Arrays no aplica bé sobre SimpleXMLElement, de fet sempre retorna "false" i ens acabem quedant sense dades:
/com/calidos/dani/php/XPathSimpleFilter.php
static private function flattenAsNeeded($content) {
// ...
363 return $content->__toString(); // FIXED: return end($content);
// ...
2. S'estava reutilitzant $structure dins d'un foreach:
/com/calidos/dani/php/XPathSimpleFilter.php
static private function flattenGivenProvisionalKeys($structure, $provisionalKeys) {
// ...
234 foreach ($structure as $k_ => $structure_) { // FIXED: foreach ($structure as $k_ => $structure) {
// ...
3. El paràmetre opcional $options es perdia en invocar recursivament function asSimpleXML:
/com/calidos/dani/php/XPathSimpleFilter.php
135 static public function asSimpleXML($structure, $options = XPathSimpleFilter::CDATAWRAP) {
// ...
137 $outXmlString_ = XPathSimpleFilter::asXML($structure, $options);
// ...
4. Afegit control a l'hora de mostrar informació de nodes aniuats més d'un nivell.
// base case
$content_ = $xml->xpath($xpath_);
// Fix when 1 element is returned as SimpleXMLElement and we want the node content
if (is_array($content_) && count($content_) === 1 ){
$content_ = $content_[0]->__toString();
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per tal que sigui compatible amb PHP 5.6, s'han fet els següents canvis:
/com/calidos/dani/php/XPathSimpleFilter.php
/com/calidos/dani/php/XPathSimpleFilter.php
/com/calidos/dani/php/XPathSimpleFilter.php