Add files via upload #2

dans-dev · 2024-09-30T09:05:45Z

No description provided.

dans-dev · 2024-09-30T09:06:06Z

donut.c

+    float A = 0, B = 0;
+    float i, j;
+    int k;
+    float z[1760];


The size of z and b should be calculated based on the loop bounds to avoid potential buffer overflows. Consider using sizeof(z) / sizeof(z[0]) and sizeof(b) / sizeof(b[0]) instead of hardcoding the values.

dans-dev · 2024-09-30T09:06:08Z

donut.c

+    float i, j;
+    int k;
+    float z[1760];
+    char b[1760];


It's good practice to use a constant for the terminal escape sequence to enhance readability and maintainability.

dans-dev · 2024-09-30T09:06:10Z

donut.c

+                }
+            }
+        }
+        printf("\x1b[H");


It might be better to use a more descriptive variable name than k for the loop counter.

dans-dev · 2024-09-30T09:06:11Z

donut.c

+        printf("\x1b[H");
+        for(k = 0; k < 1761; k++) {
+            putchar(k % 80 ? b[k] : 10);
+            A += 0.00004;


Instead of using usleep, consider using nanosleep for more precise timing control.

dans-dev · 2024-09-30T09:41:38Z

donut.c

+int main() {
+    float A = 0, B = 0;
+    float i, j;
+    int k;


Consider using bzero instead of memset for zeroing out memory. It might be slightly more efficient in this case.

dans-dev · 2024-09-30T09:41:40Z

donut.c

+        }
+        printf("\x1b[H");
+        for(k = 0; k < 1761; k++) {
+            putchar(k % 80 ? b[k] : 10);


It's good practice to add a comment explaining why you're using usleep here. It's not immediately obvious from the code.

dans-dev · 2024-09-30T09:42:59Z

donut.c

+    float i, j;
+    int k;
+    float z[1760];
+    char b[1760];


The variable z is declared with a size of 1760, but it is used with an index of o, which can potentially be greater than 1760. This could lead to out-of-bounds access and undefined behavior. Consider using a larger size for z to prevent this issue.

dans-dev · 2024-09-30T09:43:01Z

donut.c

+                float n = sin(B);
+                float t = c * h * g - f * e;
+                int x = 40 + 30 * D * (l * h * m - t * n);
+                int y= 12 + 15 * D * (l * h * n + t * m);


The variable N is used as an index into the string ".,-~:;=!*#$@", but it can potentially be negative. This could lead to out-of-bounds access and undefined behavior. Consider using abs(N) or clamping the value to the range of the string length to prevent this issue.

dans-dev · 2024-09-30T09:43:02Z

donut.c

+                int N = 8 * ((f * e - c * d * g) * m - c * d * e - f * g - l * d * n);
+                if(22 > y && y > 0 && x > 0 && 80 > x && D > z[o]) {
+                    z[o] = D;
+                    b[o] = ".,-~:;=!*#$@"[N > 0 ? N : 0];


The code uses putchar to print characters, but it doesn't handle newline characters correctly. The k % 80 condition only checks for multiples of 80, which may not align with the desired output format. Consider using a separate loop to print newlines at the end of each line.

dans-dev · 2024-09-30T09:43:04Z

donut.c

+                }
+            }
+        }
+        printf("\x1b[H");


The code uses usleep to pause execution for 30 milliseconds, which is a relatively short time. Consider using a longer delay or adjusting the update frequency of the donut animation to make it more visually appealing.

dans-dev · 2024-09-30T09:44:20Z

donut.c

+int main() {
+    float A = 0, B = 0;
+    float i, j;
+    int k;


The variable z is declared as a float array but used as an array of integers. This could lead to unexpected behavior.

dans-dev · 2024-09-30T09:44:22Z

donut.c

+        memset(b,32,1760);
+        memset(z,0,7040);
+        for(j=0; j < 6.28; j += 0.07) {
+            for(i=0; i < 6.28; i += 0.02) {


The constant 6.28 is used multiple times. Consider defining a constant for it to improve readability and maintainability.

dans-dev · 2024-09-30T09:44:23Z

donut.c

+                float n = sin(B);
+                float t = c * h * g - f * e;
+                int x = 40 + 30 * D * (l * h * m - t * n);
+                int y= 12 + 15 * D * (l * h * n + t * m);


The variable N is calculated but not used directly. This might indicate a potential bug or unused code.

dans-dev · 2024-09-30T09:44:25Z

donut.c

+                int x = 40 + 30 * D * (l * h * m - t * n);
+                int y= 12 + 15 * D * (l * h * n + t * m);
+                int o = x + 80 * y;
+                int N = 8 * ((f * e - c * d * g) * m - c * d * e - f * g - l * d * n);


The if condition checks for D > z[o] but z[o] is initialized to 0. This could lead to unexpected behavior in the first iteration.

dans-dev · 2024-09-30T09:44:26Z

donut.c

+                int o = x + 80 * y;
+                int N = 8 * ((f * e - c * d * g) * m - c * d * e - f * g - l * d * n);
+                if(22 > y && y > 0 && x > 0 && 80 > x && D > z[o]) {
+                    z[o] = D;


The variable b is declared as a character array but assigned a string. This could lead to unexpected behavior and potential memory issues.

dans-dev · 2024-09-30T09:44:27Z

donut.c

+            }
+        }
+        printf("\x1b[H");
+        for(k = 0; k < 1761; k++) {


The usleep function call is used for a delay. Consider using a more platform-independent solution, like nanosleep.

dans-dev · 2024-09-30T09:48:47Z

donut.c

+    float i, j;
+    int k;
+    float z[1760];
+    char b[1760];


It is good practice to use a descriptive variable name instead of a single letter for j and i. For example, angleJ and angleI.

dans-dev · 2024-09-30T09:48:47Z

donut.c

+        memset(b,32,1760);
+        memset(z,0,7040);
+        for(j=0; j < 6.28; j += 0.07) {
+            for(i=0; i < 6.28; i += 0.02) {


It's recommended to avoid using magic numbers. Consider defining constants for values like 6.28, 0.07, and 0.02. This will enhance code readability and maintainability.

dans-dev · 2024-09-30T09:48:48Z

donut.c

+                float D = 1 / (c * h * e + f * g + 5);
+                float l = cos(i);
+                float m = cos(B);
+                float n = sin(B);


Instead of using > and < for comparisons, using >= and <= would be more robust and prevent potential issues at the boundaries.

dans-dev · 2024-09-30T09:48:49Z

donut.c

+                    b[o] = ".,-~:;=!*#$@"[N > 0 ? N : 0];
+                }
+            }
+        }


Instead of using 10 as the newline character, use the constant \n for better readability.

dans-dev · 2024-09-30T09:48:50Z

donut.c

+        printf("\x1b[H");
+        for(k = 0; k < 1761; k++) {
+            putchar(k % 80 ? b[k] : 10);
+            A += 0.00004;


Consider using a more descriptive variable name than A and B. Names like rotationAngleA and rotationAngleB would improve code understanding.

dans-dev · 2024-09-30T09:57:43Z

donut.c

+    float A = 0, B = 0;
+    float i, j;
+    int k;
+    float z[1760];


Consider using a more descriptive variable name than z for the depth buffer. Something like depthBuffer or zBuffer would be more clear.

dans-dev · 2024-09-30T09:57:45Z

donut.c

+    float i, j;
+    int k;
+    float z[1760];
+    char b[1760];


Similarly, b could be renamed to chars or outputChars for better readability.

dans-dev · 2024-09-30T09:57:46Z

donut.c

+    float z[1760];
+    char b[1760];
+    printf("\x1b[2J");
+    for(;;) {


Adding a comment explaining the purpose of the memset calls would improve clarity.

dans-dev · 2024-09-30T09:57:48Z

donut.c

+            }
+        }
+        printf("\x1b[H");
+        for(k = 0; k < 1761; k++) {


The usleep function is non-portable. Consider using nanosleep for better portability.

dans-dev · 2024-09-30T09:57:49Z

donut.c

+            B += 0.00002;
+        }
+        usleep(30000);
+    }


It's a good practice to add a comment explaining the purpose of the return 0 statement.

Add files via upload

b79bc80

dans-dev commented Sep 30, 2024

View reviewed changes

donut.c

}

}

}

printf("\x1b[H");

Copy link

Owner Author

dans-dev Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to use a more descriptive variable name than k for the loop counter.

dans-dev commented Sep 30, 2024

View reviewed changes

Add files via upload #2

Are you sure you want to change the base?

Add files via upload #2

Uh oh!

Conversation

dans-dev commented Sep 30, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants