This repository was archived by the owner on Aug 20, 2021. It is now read-only.
Open
Conversation
asymmetric
reviewed
Feb 11, 2020
| proofs, | ||
| git: project_HEAD | ||
| git: project_HEAD, | ||
| branch: getProjectBranch() |
Contributor
There was a problem hiding this comment.
It feels like we could start adding these things to a git key, rather than having multiple keys. git.head = ...; git.branch = ..., maybe git.url in the future.
Contributor
Author
There was a problem hiding this comment.
this is a good idea, but I wonder if we will run into issues with backwards compatibility with old reports?
Contributor
There was a problem hiding this comment.
Where would this break? You'd need to change in overview.js as well ofc. Are there other coupling points?
Anyway, this doesn't have to hold back this PR.
Contributor
|
Nope, didn't find a way to test this locally, I just created it on the box and copied it by hand. You could use #342 now, which I'll rebase and merge promptly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that this should also show the git branch in the overview page (if available), but I haven't tested fully. It does correctly add the
branchto thereport.jsonwhen I runklab reportlocally.@asymmetric did you ever find a way to test this locally?
Also snuck in a few lil unrelated stylistic changes to maximize bikeshedding potential 😇
projtorev