This repository was archived by the owner on Aug 20, 2021. It is now read-only.
libexec/klab-prove-all: unaccept BADGAS specs#411
Open
asymmetric wants to merge 1 commit intomasterfrom
Open
Conversation
Remove them from the accept directory, so that the whole process is restarted. This is not ideal (since the proof had already been accepted), but the alternative risks giving false positives if one doesn't inspect the build log.
Contributor
|
Do we know why |
Contributor
Author
|
Nope, I don't know, but I would say that's out of scope for this PR, isn't it? If you look at |
Contributor
Author
|
But I do think this is not the best solution, since the proofs itself has been accepted, so I'm open to better suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove them from the accept directory, so that the whole process is restarted.
This is not ideal (since the proof had already been accepted), but the
alternative risks giving false positives if one doesn't inspect the
build log.