Use filer when running generate on DBR #4159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 56da42f
23 interesting tests: 17 KNOWN, 4 RECOVERED, 1 SKIP, 1 FAIL
Top 17 slowest tests (at least 2 minutes):
|
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik,
lennartkats-db and
pietern
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Jan 7, 2026
Comment on lines
+18
to
+19
| // This function ensures the correct filer is used based on the runtime environment. | ||
| func NewOutputFiler(ctx context.Context, w *databricks.WorkspaceClient, outputDir string) (Filer, error) { |
Contributor
There was a problem hiding this comment.
This is specific to DBR, can you move to libs/dbr?
| func testContext(t *testing.T) context.Context { | ||
| m := mocks.NewMockWorkspaceClient(t) | ||
| ctx := cmdctx.SetWorkspaceClient(context.Background(), m.WorkspaceClient) | ||
| return dbr.DetectRuntime(ctx) |
Contributor
There was a problem hiding this comment.
This evaluates differently on DBR and non-DBR. If for testing purposes, can it be fixed?
pietern
requested changes
Jan 7, 2026
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
This PR uncovered another issue on DBR. Blocking merge.
Contributor
Author
|
This approach is no longer needed. We need to add a parser for the DBR version instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates
bundle generateto use the filer abstraction for writing files instead of direct filesystem operations. This fixes thedatabricks bundle generate --bindcommand when run on DBR.In a follow-up, we can consider adding support for using FUSE instead if the DBR version is appropriate (16.4+, 2+ on serverless). I verfied that FUSE works now and gives the expected semantics necessary to write notebooks. Actually using FUSE is out of scope for this PR.
Note: Because we use BundleRootPath as the root of the file, there is a small regression where people will not be able to generate outside their bundle root (but still in their sync root).
In general generate is only meant to be run in a single bundle and is not support to create resources that are shared across bundles, so I've kept this in and am not using SyncRoot as the root of the filer (which would involve a slight refactor).
Tests
filer.NewOutputFilercovering local, DBR with non-workspace path, and DBR with workspace path scenarios