Skip to content

created util method to normalise http protocol in http path #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nikhilsuri-db wants to merge 5 commits into
base: main
Choose a base branch
from
Open

created util method to normalise http protocol in http path #724

nikhilsuri-db wants to merge 5 commits into from
+104 −6

Conversation

@nikhilsuri-db
Copy link
Contributor

@nikhilsuri-db nikhilsuri-db commented Dec 30, 2025 •
edited
Loading

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Problem
Feature flag and telemetry endpoints were double-prepending https:// when server_hostname already included the protocol, causing https://https://host.com URLs. This broke telemetry for dbt-databricks users who configure hostnames with https:// prefix.

Solution
Added normalize_host_with_protocol() utility to handle protocol normalization
Updated feature flag and telemetry clients to use: normalize_host_with_protocol(host) + "/path"
Handles hostnames with/without protocol and trailing slashes

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

#709

@nikhilsuri-db nikhilsuri-db self-assigned this Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@nikhilsuri-db
created util method to normalise http protocol in http path
14915d2 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@nikhilsuri-db
Added impacted files using util method
81ec814 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@nikhilsuri-db
Fixed linting issues
ef4f92c 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@nikhilsuri-db
fixed broken test with mock host string
e982615 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@nikhilsuri-db
mocked http client
5ae79ce 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
samikshya-db
samikshya-db approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@samikshya-db samikshya-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments, thanks!

src/databricks/sql/common/url_utils.py
(common with dbt-databricks users copying URLs from their browser).

Args:
host: Connection hostname which may or may not include a protocol prefix (https:// or http://)
Copy link
Contributor

@samikshya-db samikshya-db Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : case insensitivity should be considered

src/databricks/sql/common/url_utils.py
normalize_host_with_protocol("https://myserver.com") -> "https://myserver.com"
"""
# Remove trailing slash
host = host.rstrip("/")
Copy link
Contributor

@samikshya-db samikshya-db Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : check for NPE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samikshya-db samikshya-db samikshya-db approved these changes

Assignees

@nikhilsuri-db nikhilsuri-db

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikhilsuri-db @samikshya-db