Upgrade all mods to dbm 2.2.0 with discord.js v14 (And deletions)#986
Open
TheMonDon wants to merge 70 commits intodbm-network:beta_branch_2.2from
Open
Upgrade all mods to dbm 2.2.0 with discord.js v14 (And deletions)#986TheMonDon wants to merge 70 commits intodbm-network:beta_branch_2.2from
TheMonDon wants to merge 70 commits intodbm-network:beta_branch_2.2from
Conversation
Last time I did not know if these were different, SRD confirmed they are different.
OneAndOnlyFinbar
requested changes
Jul 2, 2023
Contributor
OneAndOnlyFinbar
left a comment
OneAndOnlyFinbar
left a comment
There was a problem hiding this comment.
Remove following from docs/mods.json
actions/anchor_create_MOD.js
actions/anchor_jump_MOD.js
actions/attach_image_to_embed_MOD.js
actions/create_forum_channel_MOD.js
Contributor
DetroitWhiskey136
left a comment
DetroitWhiskey136
left a comment
There was a problem hiding this comment.
Other than the couple things i pointed out, this all looks up to par by my untrained eye.
TheMonDon
requested review from
DetroitWhiskey136 and
OneAndOnlyFinbar
and removed request for
almeidx
Contributor
|
now you just have to get Finbar to resolve that change request. |
Contributor
|
and change the branch |
OneAndOnlyFinbar
approved these changes
Oct 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Merging all my changes I made for DBM 2.2.0 which will have discord.js v14. Removed mods talked over with staff.
Big changes:
fixed to when needed.
version updated from 2.1.7 to 2.2.0
Lots of HTML updates/fixes
Status
Semantic versioning classification: