Attempt to fix CVE-2026-1615 vulnerability#197
Open
dfop02 wants to merge 1 commit intodchester:masterfrom
Open
Attempt to fix CVE-2026-1615 vulnerability#197dfop02 wants to merge 1 commit intodchester:masterfrom
dfop02 wants to merge 1 commit intodchester:masterfrom
Conversation
|
This looks similar to what I came up with while trying to do this (just ran out of time). The idea is to have safe expressions that are allowed, and only allow those while blocking everything else. |
Author
|
Yeah @adelimon , while testing this I kept thinking that maybe I was trying to cover too many possible unsafe cases. I did my best to think through different scenarios, but there’s always a chance something was missed. Do you think it would make more sense to focus only on a clearly defined set of safe expressions instead? It feels like that might be simpler and easier to maintain than trying to block every possible unsafe pattern. I'm open to ideas and suggestions. |
|
@dchester Can you we get your input on this PR please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to Fix CVE-2026-1615: Arbitrary code injection in JSON Path expressions
Problem
The library is affected by CVE-2026-1615 (GHSA-87r5-mp6g-5w5j), mentioned on Issue 196. Script and filter expressions
?(...)and(...)were passed to static-eval with only the@variable. static-eval is not a security boundary: it still evaluates CallExpression and allows dangerous property access (e.g.constructor,__proto__), so expressions like@.constructor.constructor('return process')().exit()could lead to RCE (Node) or XSS (browser) when paths come from untrusted input.Solution
1. AST allowlist
Before calling static-eval, the expression AST is validated with
isSafeAst(). Only a fixed set of node types is allowed:Literal,Identifier(only@),MemberExpression,UnaryExpression,BinaryExpression,LogicalExpression,ConditionalExpression,ArrayExpression,ObjectExpression. Any other node type is rejected.2. Unsafe property names
Access to constructor, proto, and prototype is blocked at every
MemberExpressionso the path cannot reachFunctionor alter the prototype. The unsafe set is stored in an object built withObject.create(null)and bracket assignment so that__proto__is a normal property (object literals treat__proto__specially and would not add it as a key).3. Explicit reject list (audit-friendly)
Dangerous node types are explicitly rejected instead of relying only on default-deny:
CallExpression,NewExpression,FunctionExpression,ArrowFunctionExpressionThisExpression,AssignmentExpression,UpdateExpression,SequenceExpressionTemplateLiteral,TemplateElement,TaggedTemplateExpressionReturnStatement,ExpressionStatement4. ObjectExpression keys
For
ObjectExpression, property keys are validated (Identifier and Literal). Object literals with unsafe keys (e.g.{ "__proto__": @ },{ "constructor": @ }) are rejected.5. Single allowed variable
The only allowed identifier is
@; all others (e.g.process,eval,require,globalThis) are rejected.If the expression is not safe, evaluation is not performed and an error is thrown: "Unsafe expression: script and filter expressions may only access the current node (@) with safe property names".
Testing
@.foo["constructor"]["constructor"]("return process")().{ "__proto__": @ },{ "constructor": @ },{ "prototype": @ }.process.exit,require,eval, IIFE,new Function, method calls on@.?(@.price<10),$..book[(@.length-1)],@["@class"]) still work.139 tests pass in total.
Files changed
lib/handlers.js— Safe AST check (isSafeAst), unsafe-property map (Object.create(null)+ bracket assignment), explicit reject list, ObjectExpression key validation.test/security.js— CVE-2026-1615 suite with regression and bypass tests.Notes
JS is not my main language, so my apologies about any good-practice or patterns that I might miss here, I tried to solve the problem without generate any breaking change sanitizing the content that must be evaluated by the
static-eval.Please let me know if this approach makes sense or if there are additional improvements I should consider to ensure the issue is properly and safely resolved.