Skip to content

Conversation

@lorux0
Copy link
Contributor

@lorux0 lorux0 commented Jan 26, 2026

@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Test this pull request

  • The @dcl/protocol package can be tested in scenes by running
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-21452044758.commit-e9a8b34.tgz"

pravusjif
pravusjif previously approved these changes Jan 28, 2026
robtfm
robtfm previously approved these changes Jan 28, 2026
@lorux0 lorux0 dismissed stale reviews from robtfm and pravusjif via 440e472 January 28, 2026 18:55
@lorux0 lorux0 merged commit eae3f8b into main Jan 28, 2026
3 checks passed
@lorux0 lorux0 deleted the feat/ptr-max-player-dist-main branch January 28, 2026 21:48
kuruk-mm added a commit that referenced this pull request Jan 29, 2026
#348)

* feat: audio source & video player spatial audio (#323)

* feat: visibility component propagateToChildren (#330)

Add propagate_to_children field to PBVisibilityComponent.

The rules for propagation are introduced as code comments and are:

1. If child has own PBVisibilityComponent -> Own component takes priority, skip in propagation
2. Child's PBVisibilityComponent removed -> Re-inherit from parent hierarchy
3. Child has own component + propagateToChildren=TRUE -> Child's propagation takes over for grandchildren (blocks ancestor)
4. Child has own component + propagateToChildren=FALSE -> "Pass-through": grandchildren inherit from ancestor, not child
5. Entity reparented into non-propagating hierarchy -> Reset to visible
6. Entity reparented into propagating hierarchy -> Inherit new hierarchy visibility
7. Reparented entity has children -> Propagate visibility to all descendants of reparented entity
8. Parent's PBVisibilityComponent removed -> Children reset to visible

* feat: movePlayerTo new 'duration' field (#331)

* feat: Social service changes from experimental (#343)

* feat: extract social service changes from experimental

- Add errors.proto with social service error definitions
- Update v2/social_service_v2.proto with voice chat, community features
- Add v3/social_service_v3.proto with new social service definitions

* remove unused social service v3

* feat: pointer max player distance (#345)

* Add timestamp field to PlayerEmote message

* Add is_instant and is_emoting fields to Movement message

Cherry-picked from experimental PR #279 (fix: emotes interpolation)

---------

Co-authored-by: Gon Pombo <gonzalo@decentraland.org>
Co-authored-by: Pravus <pravusjif@gmail.com>
Co-authored-by: Nicolas Lorusso <56365551+lorux0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants