fix: DH-21670: Memory leak when using use_row_data hooks#1305
Open
mofojed wants to merge 2 commits intodeephaven:mainfrom
Open
fix: DH-21670: Memory leak when using use_row_data hooks#1305mofojed wants to merge 2 commits intodeephaven:mainfrom
mofojed wants to merge 2 commits intodeephaven:mainfrom
Conversation
Member
mofojed
commented
Feb 13, 2026
mofojed
commented
- We were not filtering the table before taking a snapshot, resulting in a snapshot of the entire table for every tick
- For big tables this is a big problem
- Just take the first row or column of the table
- Added some unit tests to verify the behaviour
- We were not filtering the table before taking a snapshot, resulting in a snapshot of the entire table for every tick - For big tables this is a big problem - Just take the first row or column of the table - Added some unit tests to verify the behaviour
|
ui docs preview (Available for 14 days) |
…patibility In Python 3.10, `import module.submodule as alias` doesn't work correctly when the parent package exports a function with the same name as the module. Using sys.modules to get the actual module objects resolves this issue.
|
ui docs preview (Available for 14 days) |
jnumainville
approved these changes
Feb 17, 2026
Collaborator
jnumainville
left a comment
jnumainville
left a comment
There was a problem hiding this comment.
One comment, but it's ignorable
| return data if is_sentinel or data is None else data.to_dict(orient="list") | ||
|
|
||
|
|
||
| def first_column_table(table: Table) -> Table: |
Collaborator
There was a problem hiding this comment.
Very nitpicky: this is fine, but you could do something to abstract the head(1) call into here as well. Currently a bit uneven of an abstraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.