Merged
Conversation
This is removing turbodbc, as we are not able to get the latest version to build (see deephaven#97). This effects our ability to test the latest version of numpy. See deephaven#71 for related concerns generally about option dependencies and the restrictions they place on server-base.
jmao-denver
reviewed
Jun 17, 2024
|
|
||
| # curl is necessary for some kafka integration testing | ||
| # unixodbc, odbc-postgresql for postgres / turbodbc integration testing | ||
| # unixodbc, odbc-postgresql for postgres integration testing |
Contributor
There was a problem hiding this comment.
Strictly we don't need these packages, but we want to keep them in case we need to do manual testing of turbodbc. Maybe a comment to make it clear?
jmao-denver
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is removing turbodbc, as we are not able to get the latest version to build (see #97). This effects our ability to test the latest version of numpy.
See #71 for related concerns generally about option dependencies and the restrictions they place on server-base.