Skip to content

feat: Extensible table options#2613

Draft
vbabich wants to merge 7 commits intodeephaven:mainfrom
vbabich:extensible-table-options
Draft

feat: Extensible table options#2613
vbabich wants to merge 7 commits intodeephaven:mainfrom
vbabich:extensible-table-options

Conversation

@vbabich
Copy link
Collaborator

@vbabich vbabich commented Jan 22, 2026

No description provided.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 50.66667% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.76%. Comparing base (0872767) to head (131299c).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
packages/plugin/src/WidgetView.tsx 0.00% 30 Missing ⚠️
...ashboard-core-plugins/src/GridMiddlewarePlugin.tsx 12.12% 29 Missing ⚠️
.../dashboard-core-plugins/src/WidgetLoaderPlugin.tsx 81.57% 14 Missing ⚠️
packages/iris-grid/src/IrisGrid.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
+ Coverage   45.94%   49.76%   +3.82%     
==========================================
  Files         771      775       +4     
  Lines       43680    43896     +216     
  Branches    11239    11109     -130     
==========================================
+ Hits        20069    21846    +1777     
+ Misses      23566    22032    -1534     
+ Partials       45       18      -27     
Flag Coverage Δ
unit 49.76% <50.66%> (+3.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks pretty good... one thing I've been mulling over the last couple days (which I'm sure you're thinking about as well) is how we'll get this to switch to a pivot table view from a default view... or do we just do a setModel or something to update the model? How would that work from re-hydration?


- Provide example plugin(s) demonstrating how to register custom Table Options menu items (if this is implemented separately from the Pivot Builder plugin)

- For the Pivot Builder - make the pivot configuration persistent. See if we can store the order of operations as part of the table state. This should probably be on the plugin side. TBD: behavior execution order when multiple plugins modify the same host component state.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need some clairfication on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants