Skip to content

Conversation

@opsiff
Copy link
Member

@opsiff opsiff commented Jan 28, 2026

deepin inclusion
category: bugfix

Edit LSM, add landlock to CONFIG_LSM.

Summary by Sourcery

Bug Fixes:

  • Include Landlock in CONFIG_LSM for Deepin loongarch and x86 desktop defconfigs so the sandboxing LSM is properly enabled by default.

deepin inclusion
category: bugfix

Edit LSM, add landlock to CONFIG_LSM.

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 28, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds the Landlock LSM to the default LSM configuration for Deepin desktop kernels on loongarch and x86, ensuring Landlock is enabled via CONFIG_LSM in both defconfig files.

File-Level Changes

Change Details Files
Enable Landlock LSM in Deepin desktop defconfigs so it is selected as part of the kernel's LSM ordering.
  • Update Deepin loongarch desktop defconfig to include landlock in CONFIG_LSM list.
  • Update Deepin x86 desktop defconfig to include landlock in CONFIG_LSM list.
arch/loongarch/configs/deepin_loongarch_desktop_defconfig
arch/x86/configs/deepin_x86_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@opsiff opsiff force-pushed the linux-6.12.y-2026-01-28-config2 branch from af59501 to 9151183 Compare January 28, 2026 10:43
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Deepin’s desktop defconfigs to include the Landlock LSM in the configured LSM stacking order so that Landlock-based sandboxing is enabled by default on supported architectures.

Changes:

  • Add landlock to CONFIG_LSM in the x86 Deepin desktop defconfig, placing it at the beginning of the LSM list.
  • Add landlock to CONFIG_LSM in the LoongArch Deepin desktop defconfig, also placing it at the beginning of the LSM list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
arch/x86/configs/deepin_x86_desktop_defconfig Adds landlock to the CONFIG_LSM list so Landlock is enabled by default on x86 Deepin desktop.
arch/loongarch/configs/deepin_loongarch_desktop_defconfig Mirrors the CONFIG_LSM update to enable Landlock by default on LoongArch Deepin desktop.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cryolitia
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff opsiff merged commit 04babd0 into deepin-community:linux-6.12.y Feb 3, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants