Skip to content

Conversation

@opsiff
Copy link
Member

@opsiff opsiff commented Jan 29, 2026

#1407 6.6

deepin inclusion
category: bugfix

Fix situation when dkms drm driver not install to light the monitor.

Link: #724
Signed-off-by: Wentao Guan guanwentao@uniontech.com
(cherry picked from commit 628373a)
Signed-off-by: Wentao Guan guanwentao@uniontech.com

Conflicts:
arch/arm64/configs/deepin_arm64_desktop_defconfig

Summary by Sourcery

Bug Fixes:

  • Fix missing monitor output on Deepin ARM64 systems when DKMS DRM drivers are not installed by enabling EFI framebuffer support in the kernel configuration.

deepin inclusion
category: bugfix

Fix situation when dkms drm driver not install to light the monitor.

Link: deepin-community#724
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
(cherry picked from commit 628373a)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

Conflicts:
	arch/arm64/configs/deepin_arm64_desktop_defconfig
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 29, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Re-enables the EFI framebuffer (FB_EFI) option in the Deepin ARM64 desktop kernel defconfig so systems still get display output even when a DKMS DRM driver is not installed or loaded.

File-Level Changes

Change Details Files
Re-enable EFI framebuffer support in the Deepin ARM64 desktop kernel configuration.
  • Turn the FB_EFI Kconfig option back on in the deepin_arm64_desktop_defconfig so the EFI framebuffer driver is built/enabled by default
  • Ensure ARM64 desktop builds retain basic display output via EFI when no dedicated DRM driver is present, matching the behavior of the referenced upstream change
arch/arm64/configs/deepin_arm64_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Avenger-285714
Copy link
Member

/approve

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Avenger-285714, lanlanxiyiji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cherry-picks a bugfix from kernel 6.6 to kernel 6.12 that enables EFI framebuffer support in the Deepin ARM64 desktop kernel configuration. The change addresses a situation where monitors fail to light up when DKMS DRM drivers are not installed, providing a fallback display mechanism via the EFI framebuffer.

Changes:

  • Changed CONFIG_FB from module to built-in, which is required for EFI framebuffer support
  • Enabled CONFIG_FB_EFI for EFI-based framebuffer support
  • Added CONFIG_XEN_FBDEV_FRONTEND module support (appears to be from conflict resolution)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CONFIG_DRM_SPRD=m
CONFIG_DRM_PHYTIUM=m
CONFIG_FB=m
CONFIG_FB=y
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONFIG_FB is being changed from module (=m) to built-in (=y), but this change is not explained in the PR description. This change is actually required because CONFIG_FB_EFI has a dependency "depends on (FB = y)" in its Kconfig definition, meaning FB must be built-in for FB_EFI to be enabled. Please update the PR description to document this necessary change and its rationale.

Copilot uses AI. Check for mistakes.
CONFIG_FB=m
CONFIG_FB=y
CONFIG_FB_EFI=y
CONFIG_XEN_FBDEV_FRONTEND=m
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of CONFIG_XEN_FBDEV_FRONTEND is not mentioned in the PR description. While this configuration option is valid and may have been added during conflict resolution (as mentioned in the PR description), it should be explicitly documented. Please update the commit message or PR description to explain why this Xen framebuffer frontend support is being added alongside FB_EFI.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants